Move microk8s to to setup test-plan and remove install-deps (New)#1989
Move microk8s to to setup test-plan and remove install-deps (New)#1989
microk8s to to setup test-plan and remove install-deps (New)#1989Conversation
Also, don't use KUBECONFIG, because that is used by kubectl for something different but related.
We are not adding the user to the microk8s group during setup
now that microk8s is installed and set up in the setup test plan
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1989 +/- ##
=======================================
Coverage 50.60% 50.60%
=======================================
Files 384 384
Lines 41180 41180
Branches 7636 7636
=======================================
Hits 20841 20841
Misses 19594 19594
Partials 745 745
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
They seem to have gotten fatter now. I see that retrying fails because: notebooks don't created in time to get removed, but then get created in time to error out creating again. We will fix this later, not this PR.
Hook25
left a comment
Hook25
left a comment
There was a problem hiding this comment.
Consider using the builtin user: directive where appropriate
I am hesitant about using Finally, while these changes are not a great example of it, I want uses of |
…#1989) * Add setup jobs for microk8s install and addons * Update DSS initialize job to use expected config * Use sudo when enabling GPU - We are not adding the user to the microk8s group during setup * Add setup jobs for microk8s to setup test plan * Migrate TF job to use setup test-plan for microk8s * Remove install-deps script * Update README for microk8s setup w/o install-deps
…#1989) * Add setup jobs for microk8s install and addons * Update DSS initialize job to use expected config * Use sudo when enabling GPU - We are not adding the user to the microk8s group during setup * Add setup jobs for microk8s to setup test plan * Migrate TF job to use setup test-plan for microk8s * Remove install-deps script * Update README for microk8s setup w/o install-deps
…#1989) * Add setup jobs for microk8s install and addons * Update DSS initialize job to use expected config * Use sudo when enabling GPU - We are not adding the user to the microk8s group during setup * Add setup jobs for microk8s to setup test plan * Migrate TF job to use setup test-plan for microk8s * Remove install-deps script * Update README for microk8s setup w/o install-deps
2 participants
Description
This PR moves the installation and setup of
microk8sto the setup test-plan originally introduced in PR #1965.The setup test-plan now includes running the newly added jobs for installing
microk8s, enabling addons in it, and exporting its kube-config. These jobs do everything thatinstall-depsscript was doing, except that we do not do the unnecessary step of adding the current user to themicrok8sgroup (hence we now need to usesudoin one new place in the test jobs where it was not previously required).The
setup.conflauncher now sets an environment variable that is used by the setup jobs to installmicrok8sfrom an appropriate channel. The template launchersetup-def.conffor the Testflinger job and GitHub workflow for DSS regression tests have been similarly updated to setup the correct value for these template parameters from the workflow's input.The
install-depsscript is now removed. It's uses in the Testflinger job templatejob-def.yaml, in thesnapcraft.yaml, and in the README have been removed.Resolved issues
CHECKBOX-1901
Documentation
The README for
checkbox-dsssnap has been updated. No changes to Checkbox's documentation.Tests
See execution of this run.